Skip to content

Fix missing close type on Connection #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix missing close type on Connection #1430

wants to merge 1 commit into from

Conversation

yesmeck
Copy link

@yesmeck yesmeck commented Oct 21, 2021 •
edited
Loading

The type of close is missing from Connection.

larshp
larshp approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@larshp larshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, https://github.com/sidorares/node-mysql2/blob/master/lib/connection.js#L723

@wellwelwel wellwelwel added typescript needs rebase For internal organization purpose needs investigation labels Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@larshp larshp larshp approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
needs investigation needs rebase For internal organization purpose typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yesmeck @larshp @wellwelwel